Skip to content

Update some VIIRS composite definitions to match WMO recommendations#3379

Merged
djhoese merged 2 commits intopytroll:mainfrom
djhoese:feat-viirs-day-cloud-comps
May 6, 2026
Merged

Update some VIIRS composite definitions to match WMO recommendations#3379
djhoese merged 2 commits intopytroll:mainfrom
djhoese:feat-viirs-day-cloud-comps

Conversation

@djhoese
Copy link
Copy Markdown
Member

@djhoese djhoese commented Apr 27, 2026 •
edited by pnuu
Loading

This PR:

  • Adds day_cloud_type_distinction
  • Deprecates cloud_phase_distinction in favor of day_cloud_type_distinction variables
  • Adds day_cloud_type
  • Replaces night_microphysics recipe with night_fog recipe

I think this matches WMO suggestions from the RGB Workshop. @adybbroe I'd like your approval on the night microphysics change.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese self-assigned this Apr 27, 2026
@djhoese djhoese added enhancement code enhancements, features, improvements component:compositors backwards-incompatibility Causes backwards incompatibility or introduces a deprecation labels Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.34%. Comparing base (4c5ade6) to head (ea93a0d).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3379      +/-   ##
==========================================
- Coverage   96.34%   96.34%   -0.01%     
==========================================
  Files         466      466              
  Lines       59160    59159       -1     
==========================================
- Hits        56995    56994       -1     
  Misses       2165     2165
Flag Coverage Δ
behaviourtests 3.58% <ø> (+<0.01%) ⬆️
unittests 96.42% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pnuu
pnuu approved these changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The only minor thing is the support only for I channel versions. For example the compact VIIRSdata we get from EUMETCast has only M channels (and partial DNB) available. I don't think we have a good way to switch between resolutions with dedicated modifiers, so the option is to keep these as-is or add "low res" versions.

@djhoese
Copy link
Copy Markdown
Member Author

djhoese commented Apr 30, 2026

I think I'd always like the highest (best) resolution version of the composite as the "default" and the lowres version as "_lowres" or something similar. I'm not sure what needs to be changed band-wise to make the low res versions. Like is M05 (0.67) really "equivalent" to I01 (0.64)?

mraspaud
mraspaud approved these changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese force-pushed the feat-viirs-day-cloud-comps branch from 1c7ea63 to c133032 Compare May 5, 2026 20:16
@djhoese djhoese force-pushed the feat-viirs-day-cloud-comps branch from c133032 to ea93a0d Compare May 6, 2026 11:54
@djhoese djhoese merged commit f49596b into pytroll:main May 6, 2026
18 checks passed
@djhoese djhoese deleted the feat-viirs-day-cloud-comps branch May 6, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mraspaud mraspaud mraspaud approved these changes

@pnuu pnuu pnuu approved these changes

@adybbroe adybbroe Awaiting requested review from adybbroe adybbroe is a code owner

Assignees

@djhoese djhoese

Labels

backwards-incompatibility Causes backwards incompatibility or introduces a deprecation component:compositors enhancement code enhancements, features, improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@djhoese @mraspaud @pnuu